feat(api): add batch issuance API endpoint with partial-failure semantics (#389) - #447
Open
bamiebot-maker wants to merge 1 commit into
Open
feat(api): add batch issuance API endpoint with partial-failure semantics (#389)#447bamiebot-maker wants to merge 1 commit into
bamiebot-maker wants to merge 1 commit into
Conversation
|
@bamiebot-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Batch issuance with partial-failure semantics (#389) is the right shape. Two checks are failing: Frontend typecheck and build, and Accessibility (axe-core). Please get both green. On the endpoint, confirm each item keeps the full per-item security model (prehash:false signing, no identity fields stored, issuer key server-side only), respects the per-item rate limit and body-size cap, and returns per-item success/error rather than all-or-nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #389
Summary of Changes
Batch Issuance Route (\POST /api/issue/batch):
Issuer Package Update (@stellarcred/issuer):
Documentation & Security:
Test Coverage: