docs: restore the asciinema demo link and embed - #386
Merged
Conversation
The recording at asciinema.org/a/qqC0RysuCDBvfUXC is reachable again (verified 200 on the page, the .svg badge, and the /iframe endpoint), so restore every reference that was dropped when it was thought expired: - README.md: the Demo header link and the asciicast embed in Overview - site/index.html: the full "See It in Action" demo section - site/README.md and CHANGELOG.md: the demo embed in the site description - audit_and_roadmap.md: the Phase 12 and Step 4 demo entries, collapsing the duplicate bullets a merge had left behind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The asciinema recording at
https://asciinema.org/a/qqC0RysuCDBvfUXCis reachable again, so this restores every reference that was dropped when it was believed to have expired:README.md— theDemolink in the header nav and the asciicast embed at the top of Overviewsite/index.html— the full<section id="demo">"See It in Action" block, restored verbatim from before its removalsite/README.mdandCHANGELOG.md— "asciinema demo embed" back in the landing-site descriptionaudit_and_roadmap.md— the Phase 12 "Demo Video" and Step 4 "Record a short demo video" entriesTwo notes for the reviewer:
audit_and_roadmap.mdappeared twice, with differently-worded removal notes ("temporarily removed while the asciinema recording is refreshed" vs. "removed as the link is no longer accessible"). That looks like a merge artifact. Each pair is collapsed back to a single restored bullet.README.md:9; theDashboardlink added since then shifted the demo down toREADME.md:10.Related Issue
Reverts the documentation half of #224, which removed these references on the grounds that the link was dead.
Motivation and Context
#224 removed the demo link because it 404'd at the time. The recording resolves again now, and the landing page has been carrying a placeholder HTML comment where its demo section used to be. The
.demo-box,.demo-player-wrapper, and.demo-fallbackrules were never deleted fromsite/styles.css, so the restored markup is styled with no CSS changes needed.How Has This Been Tested?
Docs and static-site only — no Rust code touched.
Link liveness verified before restoring rather than assumed:
https://asciinema.org/a/qqC0RysuCDBvfUXC→200, titled "Soroban Budget Assert — CI budget assertions & network-verified cost report demo"https://asciinema.org/a/qqC0RysuCDBvfUXC.svg→200,image/svg+xml(the README badge)https://asciinema.org/a/qqC0RysuCDBvfUXC/iframe→200(the landing-page embed)Added/Updated tests
Passed
cargo testPassed
cargo clippyFormatted with
cargo fmtReviewed or re-measured budget limits in
amm-pool-contract/tests/budget_test.rswhen contract, build profile, or toolchain changes may affect themTypes of changes