This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
「陽性者の属性」card 専用のファイル名を適切な名前に変更する #5277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nard-tech
changed the title
nard-tech
force-pushed
the
feature/#5276-rename-data-table-to-confirmed-cases-attributes-table
branch
from
bdb176e
to
31458bd
Compare
|
cf. #2790 (comment) |
|
別 PR で対応するため close します |
nard-tech
deleted the
feature/#5276-rename-data-table-to-confirmed-cases-attributes-table
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
⛏ 変更内容 / Details of Changes
components/DataTable.vueはその名前から様々な card で import されて使用されているかと思いきや，components/cards/ConfirmedCasesAttributesCard.vueでしか使われていない．名称から用途を想像できない上，今後 card を追加するときに変な使い方をされるおそれもあるため， card に合わせて
components/ComfirmedCasesAttributesTable.vueに改名する．utils/formatTable.tsも同様にutils/formatComfirmedCasesAttributesTable.tsに改名する．