Skip to content

feat(groups): Added New Group Chat support - #738

Open
Monsterovich wants to merge 6 commits into
TokTok:masterfrom
Monsterovich:feat-ngc
Open

Monsterovich wants to merge 6 commits into
TokTok:masterfrom
Monsterovich:feat-ngc

Conversation

@Monsterovich

@Monsterovich Monsterovich commented Aug 6, 2026 •

Copy link
Copy Markdown

Dependent: TokTok/dockerfiles#287


This change is Reviewable

@Monsterovich Monsterovich changed the title Added NGC feat(groups): Added NGC Aug 6, 2026
@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Tip

Preview URL:

@github-actions github-actions Bot added the enhancement New feature for the user, not a new feature for build script label Aug 7, 2026
@Monsterovich
Monsterovich marked this pull request as ready for review August 7, 2026 01:58
Comment thread src/widget/form/groupform.cpp Resolved
Comment thread src/widget/form/groupform.cpp Resolved
Comment thread src/widget/widget.cpp Resolved
Comment thread src/widget/form/groupinviteform.cpp Resolved
Comment thread src/core/core.cpp Resolved
Comment thread src/core/core.cpp Resolved
Comment thread src/persistence/settings.cpp Resolved
Monsterovich and others added 3 commits November 15, 2026 19:55
NGC groups next to conferences: create them, join them by chat ID, accept
group invites and invite friends, with optional passwords.

- Group topics, which respect the topic lock, and founder controls for the
  password, peer limit, privacy and voice states, topic lock and peer roles,
  and for kicking peers.
- Per-group nickname and status, and a user-set alias that falls back to
  the toxcore name.
- Private messages to group peers, with the recipient's name stored in
  the database (schema version 12).
- A group filter in the contact list, groups sorted at the top, and the
  sender's name in group chat notifications.
@Pigpog

Pigpog commented Nov 16, 2026 •

Copy link
Copy Markdown

This is really exciting! I just compiled your branch against the latest Toxcore and tried it out a bit. From my limited testing, it works!
I did notice one minor thing. If I right click a group chat peer, the context menu title seems to have junk data?

See image below - [OBJ] appears next to the peer's name for some reason. On chats the right-clicked peer owns, the star icon appears in the title correctly in addition to this [OBJ].
Screenshot from 2026-11-15 21-20-59

@iphydf

iphydf commented Nov 16, 2026

Copy link
Copy Markdown
Member

The OBJ stuff should be out now. Try again?

`curRot` was read by the first paint before the timer had set it. With a
NaN left in that memory, the rotation makes a NaN transform, and Qt 6.10+
asserts `!qIsNaN(value)` when it rounds the mapped rectangle
(qnumeric.h:561 in Qt 6.12), which crashed the Windows build on sending a
message.

This branch was successfully deployed

1 active deployment
netlify — a40d9791 Deployed Nov 17, 2026 by iphydf via netlify / deploy #802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature for the user, not a new feature for build script

Development

Successfully merging this pull request may close these issues.

4 participants