-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: windows use of REUSEADDR #2790
base: master
Are you sure you want to change the base?
Conversation
1310df4
to
eb3c8e4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2790 +/- ##
==========================================
+ Coverage 72.96% 72.98% +0.01%
==========================================
Files 149 149
Lines 30566 30572 +6
==========================================
+ Hits 22303 22313 +10
+ Misses 8263 8259 -4 ☔ View full report in Codecov by Sentry. |
Does it make sense to set both |
Tox clients failing to restart due to the toxcore being unable to bind to the same port until the original connection becomes inactive is the reason why However, we made toxcore attempt to bind to a range of ports since then, 33445-33545 inclusively by default, so perhaps the use of a range of ports mitigates this issue and it's alright to use |
eb3c8e4
to
de10ccd
Compare
de10ccd
to
45afd44
Compare
When
SO_REUSEADDR
is set on windows, it allows another process to "steal" the address, while in use.see https://learn.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse#using-so_exclusiveaddruse
This change is