feat(net): implement the last 2 missing network struct functions #2773
+193
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
force-pushed
the
network_work1
branch
6 times, most recently
from
b13285b
to
992769c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2773 +/- ##
==========================================
- Coverage 73.08% 72.99% -0.09%
==========================================
Files 149 149
Lines 30531 30575 +44
==========================================
+ Hits 22313 22319 +6
- Misses 8218 8256 +38 ☔ View full report in Codecov by Sentry. |
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
62852fe
to
b076947
Compare
Green-Sky
added
network
Green-Sky
commented
Oct 12, 2024
| @@ -1833,19 +1968,16 @@ static int addr_resolve(const Network *ns, const char *address, IP *to, IP *extr | |||
| const Family tox_family = to->family; | |||
| const int family = make_family(tox_family); | |||
|
|
|||
| struct addrinfo hints = {0}; | |||
| hints.ai_family = family; | |||
| hints.ai_socktype = SOCK_DGRAM; // type of socket Tox uses. | |||
There was a problem hiding this comment.
we are looking specifically for udp here, is this even correct??
Green-Sky
force-pushed
the
network_work1
branch
7 times, most recently
from
98d4d9b
to
23befb9
Compare
Green-Sky
changed the title
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
726b2da
to
7fb9d41
Compare
iphydf
requested changes
Nov 9, 2024
Green-Sky
force-pushed
the
network_work1
branch
from
7fb9d41
to
12a2ee8
Compare
github-actions
bot
added
the
enhancement
Green-Sky
force-pushed
the
network_work1
branch
from
12a2ee8
to
6cf8b83
Compare
|
How about the no dns variant? keep or drop? |
Green-Sky
force-pushed
the
network_work1
branch
from
6cf8b83
to
f4934d8
Compare
and make use of them
Green-Sky
force-pushed
the
network_work1
branch
from
f4934d8
to
1204c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getaddrinfoandfreeaddrinfogetaddrinfo()addr_resolve()net_getipport()os_network_no_dns()os_network()toos_network_dns()instead?This pr finally allows us to implement a regression test for #2361
Also allows fuzzing returned results from DNS.
This pr implements a different approach to disabling DNS, compared to #2694, here we can simply replace the functions pointers in the network object with dummies/stubs.
This change is