Skip to content

Conversation

@restyled-io
Copy link

@restyled-io restyled-io bot commented Jan 9, 2022

A duplicate of #1847 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • astyle
  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/c-toxcore.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

@auto-add-label auto-add-label bot added the test Adding missing tests, refactoring tests; no production code change label Jan 9, 2022
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ iphydf
✅ sudden6
❌ nurupo
You have signed the CLA already but the status is still pending? Let us recheck it.

@restyled-io restyled-io bot force-pushed the restyled/pull-1847 branch 2 times, most recently from 1f72926 to 26f00f3 Compare January 9, 2022 10:51
sudden6 and others added 9 commits January 9, 2022 12:35
This tests tox_iterate in a separate thread, and the two ToxAV modes.
This was introduced in 891fe60 and
missed, because iteration_interval() could not be called without av-
>mutex unlocked. Now both audio and video thread can. The fix moves
calculating the iteration interval, including idle interval into
iterate_common(...) which holds the correct mutex.
I don't know what this code is supposed to do, but it's clearly
accessing data once with a lock and then the same data without a lock.
Add a second lock to fix this.
@restyled-io restyled-io bot force-pushed the restyled/pull-1847 branch from 26f00f3 to faa0eb2 Compare January 9, 2022 11:35
@restyled-io restyled-io bot closed this Jan 9, 2022
@restyled-io restyled-io bot deleted the restyled/pull-1847 branch January 9, 2022 11:41
@iphydf iphydf added this to the meta milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Adding missing tests, refactoring tests; no production code change

Development

Successfully merging this pull request may close these issues.

5 participants