Skip to content

Conversation

eakmanrq
Copy link
Contributor

BREAKING: If users currently have unicode characters then their table name will update to actually include the unicode name. Still thinking through how to migrate this.

This PR affects santize_name function would before would replace unicode characters with underscores. This is used for populating the file cache and creating table names. Therefore someone could have had a SQLMesh project that would run but it would not have correct names and they could get conflicts when reading from cache or writing.

Therefore this PR updates sanitize_name to maintain the unicode characters while still removing things like double quotes from the resulting name.

@eakmanrq eakmanrq force-pushed the eakmanrq/unicode_support branch from d1c4453 to 34a5862 Compare September 30, 2025 18:40
@eakmanrq
Copy link
Contributor Author

Views don't get santiized. Therefore just the underlying tables get their unicode characters replaced which is still not optimal but not worth making this breaking change for users at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant