Skip to content

add some Workflows (Pester, PSScriptAnalyzer) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

T0biii
Copy link
Contributor

@T0biii T0biii commented Mar 4, 2025

  • dependabot for dependency updates for the actions
  • PSScriptAnalyzer
  • Pester as we got now .test files

the Pester worklow gets red if something with Pester fails
and maybe @joakimbergros got a Pester config for us?

e.g. for code scanning:
https://github.com/T0biiias/Modules.QRCodeGenerator/security/code-scanning
after merge:
https://github.com/TobiasPSP/Modules.QRCodeGenerator/security/code-scanning

we can still discuss what should be set here:
https://github.com/TobiasPSP/Modules.QRCodeGenerator/pull/24/files#diff-13c6613fa5775bc9c8a11734f08caf959197561760e0bbd87eafad1adcee3f4dR39

@joakimbergros
Copy link
Collaborator

We could put an config.pester.psd1 file in the root so it can be used by both local testing as well as the workflows.

Something like

@{
    Run = @{
        Path = '.'
    }
    CodeCoverage = @{
        Enabled = $true
    }
    TestResult = @{
        Enabled = $true
    }
}

Then we could load that file with Import-PowerShellDataFile and cast it to a PesterConfiguration object.

Let me know if this sounds good so I can create the file and adjust the tests.

@T0biii
Copy link
Contributor Author

T0biii commented Mar 4, 2025

Sounds good to me
I checked: "If checked, users with write access to TobiasPSP/Modules.QRCodeGenerator can add new commits to your add-workflows branch."
so you can directly commit on my branch https://github.com/T0biii/Modules.QRCodeGenerator/tree/add-workflows

@joakimbergros
Copy link
Collaborator

I did some restructuring for the script analyzer to be happy, let me know what you think.

… would be difficult to maintain with all different profile combinations
@T0biii
Copy link
Contributor Author

T0biii commented Mar 6, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants