Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #553
Changes
edits the
User.comment_by_idlogic to use an exponential-binary search to get comments faster.Caution
This does not work right now! This is because there is a great number of edge cases that must be considered.
and then the behaviors that correspond to them:
<,>,<=, and>=appropriately and test them wellTests
test_comment_by_id.py. In production, we will need to test this on comments on scratchattachV2