Skip to content

Conversation

@Boss-1s
Copy link
Contributor

@Boss-1s Boss-1s commented Oct 19, 2025

Solves issue #529

Changes

Removed remix_tree and remix_tree_pretty_print

Tests

No tests needed

Maybe we could @deprecate instead, since not everyone knows that they removed the remixtree endpoint

@faretek1
Copy link
Collaborator

the remixtree function was added by me a few weeks ago, after the current latest release to pypi. there's no need to use @deprecate

Copy link
Collaborator

@faretek1 faretek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a couple more things to remove

(looks like i can't manage to highlight the lines for the github review system, so i'll put some more funcnames/attrnames here):

These can be removed:

L50-51:

        self.remix_tree_children: Optional[list[Project]] = None
        self.remix_tree_parent: Optional[Project] = None

L863

@property
    def remix_depth(self) -> int:
        """
        Get the 'remix depth' of this project - i.e. the number of layers of remixing until one reaches the remix root.
        """
        if self.remix_tree_children is None:
            self.remix_tree()
        depth = 0
        p = self
        while p.remix_tree_parent:
            # this could also be done recursively, but it can hit the recursion limit in extreme cases
            # > and this happens often, because of remix chains
            p = p.remix_tree_parent
            depth += 1
        return depth

@Boss-1s Boss-1s requested a review from faretek1 October 19, 2025 22:47
@faretek1 faretek1 merged commit 8eb45ae into TimMcCool:main Oct 22, 2025
1 check passed
@faretek1
Copy link
Collaborator

faretek1 commented Oct 22, 2025

Thanks, lgtm

faretek1 added a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants