Skip to content

Conversation

@Boss-1s
Copy link
Contributor

@Boss-1s Boss-1s commented Sep 29, 2025

can solve #486

Note: For some reason my fork is showing that the commits from the last PR have not been merged, I don't know what happened there, so just ignore it and see if this PR fixes it.

Boss-1s and others added 13 commits September 26, 2025 18:19
Encountering a WebSocketBadStatusException most likely means that Scratch's cloud is down. 

Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
It seems like the scratch cloud variables are up again, so it can't really be tested anymore.
On that note, we should test if new scratchers and banned accounts can still set cloud vars.
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
@faretek1
Copy link
Collaborator

you forgot to change the message for project data warning

@faretek1
Copy link
Collaborator

faretek1 commented Sep 29, 2025

Is it possible to subclass the warnings? e.g. A class called GetWarning and then project/classroom/studio warnings subclass that, so you can disable all at once?

Or, it may be more practical for project/studio/classroom warnings to be all merged into GetWarning.

I don't enjoy the prospect of adding 4 filterwarnings to the top of my code

@Boss-1s
Copy link
Contributor Author

Boss-1s commented Sep 29, 2025

Or, it may be more practical for project/studio/classroom warnings to be all merged into GetWarning.

No, because what if someone just wants to disable one warning for some reason? I think 4 subclass would work.

Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Signed-off-by: Boss-1s <[email protected]>
Copy link
Collaborator

@faretek1 faretek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just test it (manually)

@faretek1 faretek1 self-requested a review September 29, 2025 21:20
Copy link
Collaborator

@faretek1 faretek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

- import warnings in `__init__.py`
- add 's' to filterwarning
- use newlines in warning message
- use 'scratchattach.' as a prefix
- add the note about getauthentication warning to classroom
- import warnings in studio.py
Closes 486
@faretek1 faretek1 merged commit 7a1e1e6 into TimMcCool:main Sep 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants