Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 issue resolution and CI enrichment #155

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Python 3.12 issue resolution and CI enrichment #155

merged 1 commit into from
Mar 12, 2025

Conversation

ktsitsi
Copy link
Collaborator

@ktsitsi ktsitsi commented Mar 11, 2025

This PR:

  • Introduces conditional function calls to importlib.metadata library according to the python version.
  • Adds a CI job for running CI with python 3.12 too.

@ktsitsi ktsitsi force-pushed the kt/sc-64124/import-error-while-using-python3-12 branch from f56a1fb to 81c2c5d Compare March 11, 2025 17:02
shaunrd0
shaunrd0 approved these changes Mar 12, 2025
View reviewed changes
Copy link

@shaunrd0 shaunrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ktsitsi ktsitsi merged commit 34a7180 into main Mar 12, 2025
6 checks passed
@ktsitsi ktsitsi deleted the kt/sc-64124/import-error-while-using-python3-12 branch March 12, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunrd0 shaunrd0 shaunrd0 approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

@johnkerl johnkerl Awaiting requested review from johnkerl

@XanthosXanthopoulos XanthosXanthopoulos Awaiting requested review from XanthosXanthopoulos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktsitsi @shaunrd0