Skip to content

Commit

Permalink
chore(workflows): Remove usage of deprecated set-output command
Browse files Browse the repository at this point in the history
This is necessary because Github will eventually remove this deprecated command:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
It replaced the `r0adkll/sign-android-release` github action that signs the APK
by `ilharp/sign-android-release` because this alternative version already fixed
the warnings from these deprecated commands in:
ilharp/sign-android-release#10
While the `r0adkll/sign-android-release` still haven't addressed this issue:
r0adkll/sign-android-release#80
  • Loading branch information
TiagoMSSantos committed Jul 18, 2023
1 parent 0aaa504 commit 00dd95e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,9 @@ jobs:
- name: Sign APK
timeout-minutes: ${{ fromJSON(env.GITHUB_STEP_TIMEOUT_SMALL) }}
if: success()
uses: r0adkll/sign-android-release@v1
uses: ilharp/sign-android-release@v1
with:
# Check available parameters in: https://github.com/r0adkll/sign-android-release/blob/master/action.yml
# Check available parameters in: https://github.com/ilharp/sign-android-release/blob/master/action.yml
releaseDirectory: app/build/outputs/apk/${{ matrix.type }}
signingKeyBase64: ${{ env.BASE64_KEY }}
alias: ${{ secrets.KEY_ALIAS }}
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ jobs:
# Save the path for other steps
file(TO_CMAKE_PATH "$ENV{GITHUB_WORKSPACE}/${cmake_dir}" cmake_dir)
message("::set-output name=cmake_dir::${cmake_dir}")
if (NOT "${{ runner.os }}" MATCHES "Windows")
execute_process(
Expand All @@ -168,16 +167,6 @@ jobs:
file(DOWNLOAD "${ccache_url}" ccache.tar.xz SHOW_PROGRESS)
execute_process(COMMAND ${CMAKE_COMMAND} -E tar xvf ccache.tar.xz)
- name: Prepare ccache timestamp
timeout-minutes: ${{ fromJSON(env.GITHUB_STEP_TIMEOUT_SMALL) }}
if: success()
working-directory: .
id: ccache_cache_timestamp
shell: cmake -P {0}
run: |
string(TIMESTAMP current_date "%Y-%m-%d-%H;%M;%S" UTC)
message("::set-output name=timestamp::${current_date}")
- name: Install pthread
timeout-minutes: ${{ fromJSON(env.GITHUB_STEP_TIMEOUT_MEDIUM) }}
if: success()
Expand Down

0 comments on commit 00dd95e

Please sign in to comment.