-
Notifications
You must be signed in to change notification settings - Fork 1.7k
#585 #1229 #1598 #1915 Rate limiting global configuration #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#585 #1229 #1598 #1915 Rate limiting global configuration #2294
Conversation
Hello, Milad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow card penalty! 🟨
Thank once again for submitting this PR However, after the code review, I consider it a draft.
The primary concern is the lack both unit and acceptance tests ❗
While your intention to add documentation is appreciated, please note that documentation should be written upon the completion of the code (at the end of development).
Several minor but important issues need to be addressed as listed below 👇
- I recommend starting with the file models design.
- Please be aware that the linked #1229 issue requires grouping routes by a key. Prioritize this type of grouping initially, and upon completion, proceed with the Patterns concept.
- Presenting your ideas using patterns and method grouping is also necessary. However, I do not support your idea of including the "Methods" feature, as it mixes concerns.
P.S. I will provide my vision of the model's design at a later stage.
P.P.S. I anticipate several rounds of code review. However, this feat has high priority, and I will support you through multiple pair-programming sessions.
P.P.P.S. Other members from the Ocelot development team could review this PR and provide separate code feedback 😉
Life, indeed, not easy 😛
src/Ocelot/Configuration/Creator/GlobalRateLimitOptionsCreator.cs
Outdated
Show resolved
Hide resolved
…y recognized naming convention for rate limiting features
…ons one of dynamic route
0aba615
to
a911730
Compare
Closes #585 #1229 #1915
Proposed Changes
This PR implements global rate limiting per #1229.
GlobalRateLimitOptions
in ConfigurationFileGlobalConfiguration
in FileSuccessor
Next, this pull request will be merged.
Predecessors (feature history)