Skip to content

Conversation

MiladRv
Copy link

@MiladRv MiladRv commented May 18, 2025

@coveralls
Copy link
Collaborator

coveralls commented May 19, 2025

Coverage Status

coverage: 90.173% (+0.8%) from 89.393%
when pulling 55a703b on MiladRv:feature/add-global-rate-limit
into 265f9b4 on ThreeMammals:develop.

@raman-m raman-m added feature A new feature Rate Limiting Ocelot feature: Rate Limiting Configuration Ocelot feature: Configuration labels May 19, 2025
@raman-m raman-m added this to the Spring'25 milestone May 19, 2025
@raman-m
Copy link
Member

raman-m commented May 19, 2025

Hello, Milad!
Thank you for this great PR! I'll be reviewing the code shortly...
However, since Coveralls has reported a decrease in coverage by -0.7%, we need to write unit tests—ideally covering all new code. Unit tests are a crucial part of our development process ❕ Read points 4 and 5.

@raman-m raman-m changed the title Feature: implement configuration to enable RateLimit globaly Rate limiting global configuration May 19, 2025
@raman-m raman-m requested review from RaynaldM, raman-m and ggnaegi May 19, 2025 10:04
@raman-m raman-m changed the title Rate limiting global configuration #585 #1229 #1598 #1915 Rate limiting global configuration May 19, 2025
@raman-m raman-m added the high High priority label May 19, 2025
@raman-m raman-m linked an issue May 19, 2025 that may be closed by this pull request
Copy link
Member

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yellow card penalty! 🟨

Thank once again for submitting this PR However, after the code review, I consider it a draft.
The primary concern is the lack both unit and acceptance tests
While your intention to add documentation is appreciated, please note that documentation should be written upon the completion of the code (at the end of development).

Several minor but important issues need to be addressed as listed below 👇

  1. I recommend starting with the file models design.
  2. Please be aware that the linked #1229 issue requires grouping routes by a key. Prioritize this type of grouping initially, and upon completion, proceed with the Patterns concept.
  3. Presenting your ideas using patterns and method grouping is also necessary. However, I do not support your idea of including the "Methods" feature, as it mixes concerns.

P.S. I will provide my vision of the model's design at a later stage.
P.P.S. I anticipate several rounds of code review. However, this feat has high priority, and I will support you through multiple pair-programming sessions.
P.P.P.S. Other members from the Ocelot development team could review this PR and provide separate code feedback 😉
Life, indeed, not easy 😛

@raman-m raman-m force-pushed the feature/add-global-rate-limit branch from 0aba615 to a911730 Compare September 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Ocelot feature: Configuration feature A new feature high High priority in progress Someone is working on the issue. Could be someone on the team or off. Rate Limiting Ocelot feature: Rate Limiting Summer'25 Summer 2025 release
Projects
None yet
6 participants