Skip to content

Fix escrow refund accumulation #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danitello123 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix escrow refund accumulation #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60e658a
fix(liquidity-pool): prevent i128 overflow in withdraw
Danitello123 Jul 27, 2026
0a6bf98
fix(milestone-tracker): prevent u64 overflow on deadline calculation
Danitello123 Jul 27, 2026
0338eeb
fix: escrow refund accumulation
Danitello123 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/escrow-vault/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ impl EscrowVaultContract {
let refund = escrow.locked_amount;

escrow.locked_amount = 0;
escrow.refunded_amount = refund;
escrow.refunded_amount += refund;
escrow.state = EscrowState::Refunded;

let _ttl_key = DataKey::Escrow(escrow_id);
Expand Down
5 changes: 4 additions & 1 deletion contracts/liquidity-pool/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ impl LiquidityPoolContract {
if total_shares == 0 {
panic!("no shares in pool");
}
let amount = (shares * pool.total_liquidity) / total_shares;
let amount = shares
.checked_mul(pool.total_liquidity)
.expect("share redemption calculation overflows i128")
/ total_shares;
let available = pool.total_liquidity - pool.total_borrowed;

if amount > available {
Expand Down
3 changes: 2 additions & 1 deletion contracts/milestone-tracker/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ impl MilestoneTrackerContract {
}

let now = env.ledger().timestamp();
let deadline = now + duration_secs;
let deadline = now.checked_add(duration_secs)
.expect("milestone deadline timestamp overflows u64");

let counter: u64 = env
.storage()
Expand Down