Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix area update propagation #241

Merged
merged 3 commits into from
Oct 26, 2024
Merged

fix area update propagation #241

merged 3 commits into from
Oct 26, 2024

Conversation

ThibaultJanBeyer
Copy link
Owner

Fix for #231

Issue

  • The user updates CSS Attributes on the fly
  • Those are not relevant to the positioning BUT trigger the Area to notify everyone that it has been changed
  • This notification resets the cursor position

Solution

  • Only update everyone if there is changes that actually affect the required positions, everything else we don't care

@ThibaultJanBeyer ThibaultJanBeyer merged commit 422b4e7 into main Oct 26, 2024
1 check passed
@ThibaultJanBeyer ThibaultJanBeyer deleted the #231-fix-on-fly-modifications branch October 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThibaultJanBeyer