Skip to content

Commit

Permalink
Merge branch 'RealTJ-e2e-tests'
Browse files Browse the repository at this point in the history
  • Loading branch information
Thibault Beyer authored and Thibault Beyer committed Jul 20, 2018
2 parents 8f74678 + 79e7309 commit 1f67693
Show file tree
Hide file tree
Showing 12 changed files with 10,782 additions and 26 deletions.
3 changes: 3 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": ["env"]
}
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.idea
node_modules
tests/DragSelect.js
.DS_Store
.publish
package-lock.json
Expand Down
61 changes: 52 additions & 9 deletions .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,60 @@
"globals": {
"module": true
},
"browser": true,
"boss": true,
"curly": true,
"devel":false,
"jquery": true,
"bitwise": true,
"camelcase": true,
"curly": false,
"eqeqeq": true,
"eqnull": true,
"expr": true,
"es3": false,
"forin": true,
"freeze": true,
"immed": true,
"indent": 4,
"latedef": "nofunc",
"newcap": true,
"noarg": true,
"noempty": true,
"nonbsp": true,
"nonew": true,
"plusplus": false,
"quotmark": "single",
"undef": true,
"unused": true,
"devel":false,
"jquery": true
"undef": false,
"unused": false,
"strict": false,
"maxparams": 10,
"maxdepth": 5,
"maxstatements": 40,
"maxcomplexity": 8,
"maxlen": 220,

"asi": false,
"boss": false,
"debug": false,
"eqnull": true,
"esnext": true,
"evil": false,
"expr": false,
"funcscope": false,
"globalstrict": false,
"iterator": false,
"lastsemic": false,
"laxbreak": false,
"laxcomma": false,
"loopfunc": true,
"maxerr": 50,
"moz": false,
"multistr": false,
"notypeof": false,
"proto": false,
"scripturl": false,
"shadow": false,
"sub": true,
"supernew": false,
"validthis": false,
"noyield": false,

"browser": true,
"node": true
}
31 changes: 25 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

Since I’ve not so much free time, contributions are very welcome.
Please follow this [tutorial on collaborating via github](https://www.youtube.com/watch?time_continue=4&v=81uKcXZoQ2A).
Thanks in advance!
Thanks in advance!


## Setup

Expand All @@ -23,11 +24,29 @@ it will install `gulp` for later building & open `tests/quicktest.html` for your

*Note: opening quicktest will fail on other operating systems than Mac because I’m using the mac specific `open` command to open the file. However, that is not an issue and you can go on opening the file manually.*


## Testing

You will want to see if your changes work, use `tests/quicktest.html`. Modify that file as much as you want to match your test cases.
If you feel like your test case should be permanently tested before each release, just extract it to a new file in the `tests` folder.
Write what to test & name it `test#.html` where `#` is the next available number.
- You will want to see if your changes work, use `tests/quicktest.html`. Modify that file as much as you want to match your test cases.

### Automatic

For the testing puppeteer and jest is used. Puppeteer will be installed locally, but can be a bit heavy (~200mb) you can use the [Environment Variables](https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#environment-variables) if you have puppeteer installed already.

Automated tests are run via:

```
npm test
```

There aren’t many automated tests yet. So please also test manually:

### Manual

- If you feel like your test case should be permanently tested before each release, just extract it to a new file in the `tests` folder.

- Write what to test & name it `test#.html` where `#` is the next available number.

- Once you are happy with your changes, **always test all test scenarios in `tests/`**. I.e. `tests/test1.html`, `tests/test2.html` etc.

Once you are happy with your changes, **always test all test scenarios in `tests/`**. I.e. `tests/test1.html`, `tests/test2.html` etc.
Unfortunately, this has to be done manually at the moment.
- Unfortunately, this has to be done manually at the moment.
Loading

0 comments on commit 1f67693

Please sign in to comment.