bugfix(gui): fix the ability to enable the scroll anchor in the game options.ini #1500
+59
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
commented
Aug 26, 2025
| @@ -1854,7 +1896,7 @@ void OptionsMenuInit( WindowLayout *layout, void *userData ) | |||
| //set scroll options | |||
| AsciiString test = (*pref)["DrawScrollAnchor"]; | |||
| DEBUG_LOG(("DrawScrollAnchor == [%s]", test.str())); | |||
| if (test == "Yes" || (test.isEmpty() && TheInGameUI->getDrawRMBScrollAnchor())) | |||
| if (test == "yes" || (test.isEmpty() && TheInGameUI->getDrawRMBScrollAnchor())) | |||
There was a problem hiding this comment.
These blocks of code currently don't get hit since the options related to them are not implemented in the option menu, but i tweaked the text to match other places.
Mauller
commented
Aug 26, 2025
| //------------------------------------------------------------------------------------------------- | ||
| // draw scroll anchor | ||
| { | ||
| if( TheInGameUI->getDrawRMBScrollAnchor() ) |
There was a problem hiding this comment.
These are here to allow the option to be saved to the options.ini as the other options menu code related to the scroll anchor is never hit in the current options menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the scroll anchor option to be set in the options.ini and for it to be usable ingame.
The game appears as though it was going to get radio buttons in the options menu to enable the scroll anchor, but it appears that it was never fully implemented.
The code for using the scroll anchor all works, the ability to enable and use it was just never fully implemented.
This code uses the same pattern we have used in the past for enabling new options in the global data for new options.ini features.
Said scroll anchor appears when people use RMB scrolling and gives people an idea of where their scrolling origin is located.
It is currently disabled by default, but people can enable it by setting "yes" next to the relevant option after having saved settings on the options menu at least once.
TODO: