Skip to content

buzz-db: deduplicate row_to_channel_record between channel.rs and dm.rs #18

Description

@TheSentinel454

dm.rs defines its own row_to_channel_record (line 487, ~30 lines) returning the same ChannelRecord type from channel.rs. The two implementations must stay in sync manually — any column added to ChannelRecord requires updating both mappers. Fix: make the channel module's mapper pub(crate) and import it in dm.rs, or apply #[derive(FromRow)] per #15. Priority: Low — small cleanup, risk of divergence.

🤖 AI review update (2026-08-23)

This is a good small cleanup or the first acceptance item in #15. Prefer one canonical mapper or one proven FromRow implementation, with a test that exercises the DM query shape against the shared ChannelRecord. Do not wait for the full lib.rs breakup if this can be removed safely now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions