Skip to content

Inline ASM: switch to intel syntax - #132

Merged
Neffi42 merged 2 commits into
mainfrom
40-try-to-implement-intel-syntax-in-asm_volatile
Oct 12, 2025
Merged

Neffi42 merged 2 commits into
mainfrom
40-try-to-implement-intel-syntax-in-asm_volatile

Conversation

@Neffi42

@Neffi42 Neffi42 commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Neffi42
Neffi42 requested a review from iamantoinev as a code owner October 12, 2025 15:06
Copilot AI review requested due to automatic review settings October 12, 2025 15:06
@Neffi42 Neffi42 self-assigned this Oct 12, 2025
@Neffi42 Neffi42 linked an issue Oct 12, 2025 that may be closed by this pull request
@Neffi42
Neffi42 enabled auto-merge (squash) October 12, 2025 15:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches inline assembly code from AT&T syntax to Intel syntax for better readability and consistency. The key motivation is to use the more intuitive Intel syntax where operands flow from source to destination.

Key changes:

  • Updated compiler flags to enable Intel syntax with -masm=intel
  • Converted inline assembly statements from AT&T to Intel syntax across multiple files
  • Modified register operations and I/O instructions to follow Intel conventions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
config.mk Added -masm=intel compiler flag to enable Intel syntax
kernel/src/utils.c Converted mov instruction from AT&T to Intel syntax
kernel/include/kpanic.h Updated XOR operations to Intel syntax
kernel/include/io.h Converted I/O instructions (in/out) to Intel syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread kernel/include/io.h
Comment thread kernel/include/io.h
Comment thread kernel/include/io.h
@Neffi42
Neffi42 force-pushed the 40-try-to-implement-intel-syntax-in-asm_volatile branch from e624e6f to d45f64a Compare October 12, 2025 15:09
@Neffi42
Neffi42 requested a review from Copilot October 12, 2025 15:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread kernel/include/io.h Outdated
Comment thread kernel/include/io.h Outdated
@Neffi42
Neffi42 force-pushed the 40-try-to-implement-intel-syntax-in-asm_volatile branch from d45f64a to e25a238 Compare October 12, 2025 15:13
@sonarqubecloud

Copy link
Copy Markdown

@Neffi42
Neffi42 merged commit 40a0965 into main Oct 12, 2025
4 checks passed
@Neffi42
Neffi42 deleted the 40-try-to-implement-intel-syntax-in-asm_volatile branch October 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try to implement intel syntax in asm_volatile

3 participants