Repository navigation
Physical Memory Manger v2 - #131
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Physical Memory Manager (PMM) v2 to replace the previous frame allocation system. The implementation introduces a more sophisticated memory management approach with bitmap-based tracking and improved integration with the multiboot protocol.
- Replaces the old frame allocation system with a new PMM that uses bitmap-based memory tracking
- Integrates multiboot memory detection to determine total available memory
- Implements pre-allocation optimization for better performance
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kernel/src/memory/pmm.c | New PMM implementation with bitmap-based frame allocation and pre-allocation optimization |
| kernel/src/memory/paging.c | Updated to use new PMM functions and improved page table setup |
| kernel/src/memory/frame.c | Removed old frame allocation system |
| kernel/src/kernel.c | Added multiboot memory detection and initialization of PMM before paging |
| kernel/src/boot.asm | Passes multiboot parameters to kernel_main |
| kernel/include/pmm.h | Header for new PMM with frame_map_t structure and function declarations |
| kernel/include/paging.h | Updated function name from paging_setup to paging_init |
| kernel/include/multiboot.h | Complete multiboot specification header for memory detection |
| kernel/include/frame.h | Removed old frame allocation header |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@antoineverin |
Neffi42
enabled auto-merge (squash)
October 10, 2025 13:56
iamantoinev
reviewed
Oct 11, 2025
|
iamantoinev
self-requested a review
October 12, 2025 16:25
iamantoinev
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.