Skip to content

Physical Memory Manger v2 - #131

Merged
Neffi42 merged 4 commits into
mainfrom
test-memory
Oct 12, 2025
Merged

Neffi42 merged 4 commits into
mainfrom
test-memory

Conversation

@Neffi42

@Neffi42 Neffi42 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Neffi42 Neffi42 self-assigned this Oct 10, 2025
@Neffi42
Neffi42 requested a review from iamantoinev as a code owner October 10, 2025 13:47
Copilot AI review requested due to automatic review settings October 10, 2025 13:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new Physical Memory Manager (PMM) v2 to replace the previous frame allocation system. The implementation introduces a more sophisticated memory management approach with bitmap-based tracking and improved integration with the multiboot protocol.

  • Replaces the old frame allocation system with a new PMM that uses bitmap-based memory tracking
  • Integrates multiboot memory detection to determine total available memory
  • Implements pre-allocation optimization for better performance

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
kernel/src/memory/pmm.c New PMM implementation with bitmap-based frame allocation and pre-allocation optimization
kernel/src/memory/paging.c Updated to use new PMM functions and improved page table setup
kernel/src/memory/frame.c Removed old frame allocation system
kernel/src/kernel.c Added multiboot memory detection and initialization of PMM before paging
kernel/src/boot.asm Passes multiboot parameters to kernel_main
kernel/include/pmm.h Header for new PMM with frame_map_t structure and function declarations
kernel/include/paging.h Updated function name from paging_setup to paging_init
kernel/include/multiboot.h Complete multiboot specification header for memory detection
kernel/include/frame.h Removed old frame allocation header

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread kernel/src/memory/pmm.c
Comment thread kernel/src/kernel.c Outdated
Comment thread kernel/src/kernel.c Outdated
@Neffi42

Neffi42 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

@Neffi42
Neffi42 enabled auto-merge (squash) October 10, 2025 13:56
Comment thread kernel/src/boot.asm
Comment thread kernel/src/kernel.c Outdated
@sonarqubecloud

Copy link
Copy Markdown

@iamantoinev
iamantoinev self-requested a review October 12, 2025 16:25
@Neffi42
Neffi42 merged commit 28680c5 into main Oct 12, 2025
4 checks passed
@Neffi42
Neffi42 deleted the test-memory branch October 12, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants