Repository navigation
remove release flags - #120
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes release and optimization flags from the build configuration to simplify debugging by making stack traces more readable. The change forces all builds to use debug settings with -O0 -g flags.
- Removes conditional DEBUG flag handling in config.mk
- Consolidates CFLAGS to always use debug optimization level
- Simplifies debug target in Makefile to directly use existing binary
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config.mk | Removes release/debug flag conditionals and hardcodes debug flags (-O0 -g) into CFLAGS_COMMON |
| Makefile | Simplifies debug target to use existing binary instead of rebuilding with DEBUG=1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Antoine Verin <24255551+antoineverin@users.noreply.github.com>
|
iamantoinev
enabled auto-merge (squash)
September 19, 2025 13:12
Neffi42
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove release and optimization flags, as they make the stack booooh