Fix crash on invalid rails6-format cookie#1
Open
guisehn wants to merge 4 commits into
Open
Conversation
guisehn
commented
Dec 16, 2024
Comment on lines
+66
to
+90
| padding = <<2, 2>> | ||
| assert decrypted == {:ok, data <> padding} | ||
| end | ||
|
|
||
| test "it uses only the first 32 bytes to authenticate and encrypt/decrypt" do | ||
| data = <<0, "helloworld", 0>> | ||
| padding = <<4, 4, 4, 4>> | ||
| encrypted = ME.encrypt_and_authenticate(<<0, "helloworld", 0>>, @large) | ||
|
|
||
| decrypted = ME.authenticate_and_decrypt(encrypted, @large) | ||
| assert decrypted == {:ok, data} | ||
| assert decrypted == {:ok, data <> padding} | ||
|
|
||
| decrypted = ME.authenticate_and_decrypt(encrypted, @right) | ||
| assert decrypted == {:ok, data} | ||
| assert decrypted == {:ok, data <> padding} | ||
|
|
||
| decrypted = ME.verify_and_decrypt(encrypted, @right, @right) | ||
| assert decrypted == :error | ||
|
|
||
| encrypted = ME.encrypt_and_authenticate(<<0, "helloworld", 0>>, @right) | ||
|
|
||
| decrypted = ME.authenticate_and_decrypt(encrypted, @large) | ||
| assert decrypted == {:ok, data} | ||
| assert decrypted == {:ok, data <> padding} | ||
|
|
||
| decrypted = ME.authenticate_and_decrypt(encrypted, @right) | ||
| assert decrypted == {:ok, data} | ||
| assert decrypted == {:ok, data <> padding} |
Author
There was a problem hiding this comment.
Those tests were failing, padding-removal code was removed on 541b0c5 but tests were not updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing an invalid cookie in Rails 6 format (with 3 parts),
MessageEncryptor.authenticate_and_decrypt/2could cause exceptions:ArgumentErrorlike:or:
{:ok, :error}instead of{:error}, which would crash on:We fixed to return just
:errorin both cases, which gracefully falls back to an empty session.