Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master Pull - Picking changes from Original Postmill #200

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Master Pull - Picking changes from Original Postmill #200

wants to merge 27 commits into from

Conversation

psineur
Copy link
Contributor

@psineur psineur commented Apr 23, 2018

Keeping track, we want to merge most of the things, because:

  1. If PostMill suddenly becomes popular - it will make it easier for us to merge (unlikely)
  2. Free bug fixes / possibly features
  3. Insight into legacy codebase, from it's author

THIS SHOULD NEVER BE MERGED, NOR REBASED

We will update this PR from time to time, adding new commits from gitlab.com/edgyemma/Postmill master branch. Do not rebase it - we're keeping original timeline.

We will cherry-pick commits from this PR into it's own PRs, clean it up and merge if needed.
Here we will keep logs, checkmark means it was merged.

15 Apr 2018 Pass

🙏 Features we needed:

🐁 No cost to merge changes(small, css, ui, etc):

🚢 More or Less Usefull changes:

🆗 Unit Tests:

📦 Interesting Possibly Very Useful / Bigger Changes

😒 Ignored Changes - unimportant:

⛔️ Ignored Changes - Conflicts:

  • SubmissionImageListener - we're going different route (495261a)

Emma and others added 27 commits March 25, 2018 03:14
update dependencies (fixes broken comments page)
3d89b29
prevent long site names from wrapping
22575f5
update notice/new project URL
5b928ae
added webhooks
c436a96
add webhook documentation to index
7b015df
refactor SubmissionImageListener to use guzzle
495261a
factor EntityEditListener away
b12fecc
remove unnecessary service dependency
d892901
Updated Esperanto translation.
e80c652 
Corrected errors, used easier words.
update dependencies (fixes cache warmup)
1c9a69a
replace deprecated psr-0 type hints with psr-4
5957028
Merge branch 'master' into 'master'
69bf21f 
Updated Esperanto translation.

See merge request edgyemma/Postmill!41
add NotForumBanned constraint/validator
b03c095
Merge branch 'master' of gitlab.com:edgyemma/Postmill
960595e
update dependencies
097ee45
fix unit tests
6368e3d
test Votable/minor refactorings for voting stuff
23d7e67
give AjaxListener a proper unit test
049b378
completely redo the way submissions are fetched
d4325c1 
adds:

- keyset pagination (fast!)
- ability to limit to forums/users, and exclude forums/users
- reintroduced top/controversial sort modes
- adds a new 'most commented' sort mode

removes:

- previous button (no one cared anyway)
Merge branch 'feat-keyset-pagination' into 'master'
4eabd19 
completely redo the way submissions are fetched

Closes #8 and #11

See merge request edgyemma/Postmill!42
fix typo that broke 'controversial'
8568c41
rearrange some classes, remove dead code
0a1e653
fix validation in SubmissionPager
64caf47
remove deprecated css classes
8a7f61a
add command for modifying a user
ed81769
make vote buttons use event bubbling
42b29a7
update readme
127aa1e
@psineur psineur added DO NOT MERGE External, Bad, Untested, Untrusted, WIP, etc Real Communism... ... hasn't been tried yet 3edgy5me edgyemma - PostMill author, unstable labels Apr 23, 2018
@psineur psineur self-assigned this Apr 23, 2018
This was referenced Apr 25, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@psineur psineur

Labels
3edgy5me edgyemma - PostMill author, unstable DO NOT MERGE External, Bad, Untested, Untrusted, WIP, etc Real Communism... ... hasn't been tried yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psineur