Skip to content

Revert "⚡ Parallelize API calls in SharedViewModel for faster session refresh" #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealAshik merged 1 commit into from
Jan 29, 2026
Merged

Revert "⚡ Parallelize API calls in SharedViewModel for faster session refresh" #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions composeApp/src/commonMain/kotlin/dev/therealashik/client/jules/viewmodel/SharedViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.async
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import kotlinx.datetime.Clock
Expand Down Expand Up @@ -312,11 +311,11 @@ class SharedViewModel : ViewModel() {
// Check if we are still looking at this session
if (_uiState.value.currentSession?.name != sessionName) return

// Parallel fetch for better performance
// Parallel fetch could be better but sequential is safer for now
val (activitiesResp, session) = withContext(Dispatchers.IO) {
val act = async { api.listActivities(sessionName) }
val sess = async { api.getSession(sessionName) }
act.await() to sess.await()
val act = api.listActivities(sessionName)
val sess = api.getSession(sessionName)
act to sess
}

val isProcessing = session.state == SessionState.QUEUED ||
Expand Down
Loading