Ensure tab links conform to WCAG 2.1 AA guidelines (PP-3575)#192
Merged
PoorBillyPilgrim merged 1 commit intomainfrom Feb 4, 2026
Merged
Ensure tab links conform to WCAG 2.1 AA guidelines (PP-3575)#192PoorBillyPilgrim merged 1 commit intomainfrom
PoorBillyPilgrim merged 1 commit intomainfrom
Conversation
…ections within the DOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tab links throughout the app were provided href values of
javascript:void(0)to prevent navigation. These void calls were replaced with identifiers that reference actual sections within the app.Motivation and Context
Using
javascript:void(0)calls provide a poor experience for users as they provide no indication that a real destination exists for the link within the document. Ideally, we would make these elements buttons, but we are currently constrained byreact-bootstrapand how it implements tabs. The alternatives: 1) remove theevent.preventDefault()and the tabs will navigate appropriately, but this causes a full page reload every time byreact-router, or 2) swap the links with buttons, but this would break much of the functionality and visual styling.PP-3575
How Has This Been Tested?
Manually tested that the tabbing still works as intended.
Checklist: