07_reverseString: handle Unicode surrogate pairs in reverseString solution #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The original
reverseString
solution used.split("")
, which does not handle complex Unicode characters correctly. This can lead to incorrect behavior when the input includes surrogate pairs (e.g., emojis or some accented characters). This PR modifies the implementation to avoid that issue and includes a comment to make learners aware of the underlying limitation.This PR
reverseString
solution to useArray.from()
instead of.split("")
Issue
N/A
Additional Information
We've already been exposed to this problem in the MDN Reference page for String, linked here. This is why I think we can consider it in this exercise.
Pull Request Requirements
location of change: brief description of change
format, e.g.01_helloWorld: Update test cases
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section/solutions
folder