Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README to clarify hash functionality not needed #6

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Conversation

Forthoney
Copy link
Contributor

@Forthoney Forthoney commented Sep 14, 2022

Added a sentence clarifying the scope of the task to just Arrays in line 67 of README.md
Fixes #5

Copy link
Member

@ChargrilledChook ChargrilledChook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay getting back to you on this one @Forthoney. Great change, I only have one small suggestion. Let me know your thoughts then we can get this one merged 🚀

@Forthoney
Copy link
Contributor Author

@ChargrilledChook Sounds much clearer! Thanks for the feedback

Copy link
Member

@ChargrilledChook ChargrilledChook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Forthoney!

@ChargrilledChook ChargrilledChook merged commit f3e12d5 into TheOdinProject:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear instructions on whether custom Enumerable module should be usable on non-Array objects
2 participants