Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-on-rails-advanced-forms: Add link to docs on checkbox gotcha #29096

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

dwlknsn
Copy link
Contributor

@dwlknsn dwlknsn commented Nov 19, 2024

Because

Helps to clarify that a form not submitting the params for a deselected checkbox/select form field is a feature of the HTML spec, not an unintended side-effect. It's a known gotcha, but reads like a bit of an unintended side effect.

The rails API guides includes a helpful section with details of this gotcha and why a hidden field is required, including examples of the HTML output.

This PR

  • adds a link to the rails API guides to clarify the hidden form fields on checkboxes

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Nov 19, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea and improvement. Just one small change to make the link more accessible, and I'll merge it in 🚀

@JoshDevHub JoshDevHub self-assigned this Nov 20, 2024
@dwlknsn
Copy link
Contributor Author

dwlknsn commented Nov 21, 2024

@JoshDevHub - suggestion applied, thanks. Ready for review and merge 🚀

@JoshDevHub JoshDevHub merged commit 8432c18 into TheOdinProject:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants