Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulma instructions | rails | actioncable #29086

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sean-garwood
Copy link
Contributor

  • @use: "bulma" instead of @import
  • import hangouts.scss in application.scss
    • not sure if necessary, but it's what worked
  • instructions for recompiling assets
    • ./bin/dev
    • rails assets:precompile

chore: remove bundle exec | rails | actioncable

Removes redundant bundle exec from rails
commands

see
https://old.reddit.com/r/rails/comments/119v666/difference_between_rails_dbmigrate_and_bundle/j9p0dm0/

Because

Had some trouble getting bulma to work, so dug in a bit and found the solutions. Added to this lesson

This PR

  • @use: "bulma" instead of @import
  • import hangouts.scss in application.scss
    • not sure if necessary, but it's what worked
  • instructions for recompiling assets
    • ./bin/dev
    • rails assets:precompile

chore: remove bundle exec | rails | actioncable

  • Removes redundant bundle exec from rails
    commands

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

* `@use: "bulma"` instead of `@import`
* import hangouts.scss in application.scss
  * not sure if necessary, but it's what worked
* instructions for recompiling assets
  * `./bin/dev`
  * `rails assets:precompile`

chore: remove `bundle exec` | rails | actioncable

Removes redundant `bundle exec` from `rails`
commands

see
https://old.reddit.com/r/rails/comments/119v666/difference_between_rails_dbmigrate_and_bundle/j9p0dm0/
@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Nov 14, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! Thank you for updating this lesson.

@JoshDevHub JoshDevHub merged commit 3556243 into TheOdinProject:main Nov 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants