Skip to content

New lesson: Cookies #28974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

New lesson: Cookies #28974

wants to merge 11 commits into from

Conversation

mao-sz
Copy link
Contributor

@mao-sz mao-sz commented Oct 19, 2024 •
edited
Loading

Because

Part of the Node Revamp milestone 2 - new lesson on Cookies.

This PR

  • Adds a new Cookies lesson to the Node.js course - Authentication section.

Issue

Closes #28848

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Oct 19, 2024
@mao-sz mao-sz added the Project Node Revamp Issues/PRs related to the Node Revamp project label Oct 19, 2024
@mao-sz mao-sz added this to the Node Revamp: Milestone # 2 milestone Oct 19, 2024
@mao-sz mao-sz changed the title Node revamp cookies New lesson: Cookies Oct 19, 2024
@mao-sz mao-sz mentioned this pull request Nov 13, 2024
Open
7 tasks
@mao-sz
Streamline verbiage
9d8206c 
Remove duplicate line
@mao-sz mao-sz marked this pull request as ready for review November 13, 2024 15:53
@01zulfi 01zulfi self-requested a review November 13, 2024 16:19
Asartea
Asartea reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@Asartea Asartea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Lofty-Brambles
Copy link
Contributor

Short and to the point. LGTM!

@mao-sz @Asartea
Tweak verbiage
421745e 
Co-authored-by: Asartea <[email protected]>
01zulfi
01zulfi reviewed Nov 25, 2024
View reviewed changes
01zulfi
01zulfi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@01zulfi 01zulfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gets the job done 👍

(Mao, I swear this is a compliment 😭 )

@mao-sz
Remove section on SameSite attribute
2376ae5 
No longer relevant to the course - cross-site stuff later in the
curriculum now handled in a way that does not require setting SameSite=None etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@01zulfi 01zulfi 01zulfi approved these changes

+1 more reviewer

@Asartea Asartea Asartea left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Content: NodeJS Involves the NodeJS course Project Node Revamp Issues/PRs related to the Node Revamp project
Projects
None yet
Milestone
Node Revamp: Milestone # 2
Development

Successfully merging this pull request may close these issues.

New Lesson: Cookies
4 participants
@mao-sz @Lofty-Brambles @Asartea @01zulfi