Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix> Changed tabIndex of second element to 1 - Advanced HTML and CSS / Keyboard Navigation #28657

Closed
wants to merge 1 commit into from

Conversation

MevWebDev
Copy link
Contributor

@MevWebDev MevWebDev commented Aug 18, 2024

Because

There was a mistake that didn't make sense. Two elements had the same tabIndex

This PR

Changed tabIndex of 2nd element to 1

Issue

Used improve button

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Aug 18, 2024
@MevWebDev MevWebDev changed the title <fix> Changed tabIndex of second element to 1 <fix> Changed tabIndex of second element to 1 - Advanced HTML and CSS / Keyboard Navigation Aug 18, 2024
@MevWebDev MevWebDev closed this Aug 18, 2024
@MevWebDev MevWebDev deleted the patch-1 branch August 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant