Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack: Fix HtmlWebpackPlugin script tag reference #28656

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Webpack: Fix HtmlWebpackPlugin script tag reference #28656

merged 1 commit into from
Aug 18, 2024

Conversation

Maddily
Copy link
Contributor

@Maddily Maddily commented Aug 18, 2024

Because

This PR corrects the explanation of HtmlWebpackPlugin’s behavior in the Webpack lesson. The previous text inaccurately stated that HtmlWebpackPlugin adds a script tag to the main.js file. The update clarifies that HtmlWebpackPlugin actually adds the script tag to the index.html file.

This PR

  • Updated the lesson text to specify that the script tag is added to index.html rather than main.js.

Issue

Closes #XXXXX

Additional Information

N/A

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Aug 18, 2024
@Maddily Maddily changed the title Fix HtmlWebpackPlugin script tag reference Webpack: Fix HtmlWebpackPlugin script tag reference Aug 18, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, silly error!

@MaoShizhong MaoShizhong merged commit 7347870 into TheOdinProject:main Aug 18, 2024
3 checks passed
@Maddily Maddily deleted the webpack-clarify-html-script-tag branch August 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants