Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Message: Add section how to create commit message with subject #28655

Merged
merged 5 commits into from
Aug 18, 2024

Conversation

nguyenlekhtn
Copy link
Contributor

@nguyenlekhtn nguyenlekhtn commented Aug 18, 2024

Because

Commit Message lesson introduced "commit with subject" but doesn't show how to make ones

This PR

  • Show how to make a commit with subject and body in message
  • Add a quick link to remind about changing the commit editor from Git Basics to make sure learners have changed it to VS Code.

Issue

Closes #28471

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Git Involves Git content label Aug 18, 2024
@nguyenlekhtn nguyenlekhtn changed the title Commit Messages Commit Message: Add section to show how to create commit message with subject Aug 18, 2024
Add section 'How to create commit with subject and body in message'
@nguyenlekhtn nguyenlekhtn changed the title Commit Message: Add section to show how to create commit message with subject Commit Message: Add section how to create commit message with subject Aug 18, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! Just a couple of nits and change of section location, but otherwise, thanks for getting this added!

git/foundations_git/commit_messages.md Outdated Show resolved Hide resolved
git/foundations_git/commit_messages.md Outdated Show resolved Hide resolved
git/foundations_git/commit_messages.md Outdated Show resolved Hide resolved
git/foundations_git/commit_messages.md Outdated Show resolved Hide resolved
git/foundations_git/commit_messages.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@MaoShizhong MaoShizhong merged commit 34261ab into TheOdinProject:main Aug 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Git Involves Git content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foundations: git commit without m option should be introduced in Commit Messages lesson
2 participants