Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motivation and Mindset: Replace 'checkout' with 'check out' and apply hyperlink to 'this article' instead #28607

Closed
wants to merge 3 commits into from

Conversation

SuleymanCommits
Copy link
Contributor

@SuleymanCommits SuleymanCommits commented Aug 10, 2024

Because

It fixes a grammatical error. Checkout is a noun that refers to taking items out of a store after paying. Check out is the intended verb here.
It also changes the hyperlink to point to 'this article' instead of 'more information on breaks and productivity' as that is more in line with web standards.

This PR

  • Replace improper noun 'checkout' with proper verb 'check out'

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Aug 10, 2024
@SuleymanCommits
Copy link
Contributor Author

SuleymanCommits commented Aug 10, 2024

I would argue that 'this article' should be part of the hyperlink

@SuleymanCommits SuleymanCommits changed the title Motivation and Mindset: Replace 'checkout' with 'check out' Motivation and Mindset: Replace 'checkout' with 'check out' and encapsulate 'this article' Aug 10, 2024
@SuleymanCommits
Copy link
Contributor Author

SuleymanCommits commented Aug 10, 2024

maybe even apply the hyperlink only to 'this article' and not 'more information on breaks & productivity'? Thoughts?

@SuleymanCommits SuleymanCommits changed the title Motivation and Mindset: Replace 'checkout' with 'check out' and encapsulate 'this article' Motivation and Mindset: Replace 'checkout' with 'check out' and apply hyperlink to 'this article' Aug 10, 2024
@SuleymanCommits SuleymanCommits changed the title Motivation and Mindset: Replace 'checkout' with 'check out' and apply hyperlink to 'this article' Motivation and Mindset: Replace 'checkout' with 'check out' and apply hyperlink to 'this article' instead Aug 10, 2024
@SuleymanCommits
Copy link
Contributor Author

never mind, my bad, I'll open a new PR for 'checkout' to 'check out'. Sorry for the clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant