-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails: Update link texts to improve accessibility #28293
Rails: Update link texts to improve accessibility #28293
Conversation
Should I fix the linting issues as well? The issue mentioned to let them be |
For these, I can trust you to address any reasonable lint errors. Most should be fixable using the appropriate npm fix scripts, then if any obvious ones remain, you can manually fix those. Feel free to ask any questions if you encounter any less clear lint errors. |
Yes they were really easy fixes, but the linter still screams, it requires a section on lesson overview, can i work on it as well? Also there's an error which didn't make sense to me
It's a Edit: I forgot to ask for another change i made, in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the lesson overview errors alone - those require much more thought and won't be appropriate to resolve in this PR.
The error regarding ### Knowledge checks
is because the heading is called Knowledge checks
when it should be Knowledge check
. De-pluralising checks
will let the linter recognise it as the appropriate section, thus allowing the h3
.
Regarding the two changed headings in the websockets lesson, what you have I believe should be fine. You will need to use sentence case though, so they should be changed to WebSocket connections
and Client-server connections
.
I believe this should do it, also I moved the |
ruby_on_rails/mailers_advanced_topics/websockets_and_actioncable.md
Outdated
Show resolved
Hide resolved
Co-authored-by: MaoShizhong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Because
Revise the link texts as per the instructions given in the issue.
This PR
Issue
Related to #28290
Additional Information
nil
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section