Project: Custom Enumerables: Added link to Additional resources list #28277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a link to an article that I found very helpful in getting me started on the project.
CouchofTomato
approved these changes
Jun 26, 2024
|
There's a few linting issues with this lesson. Are you happy to try and address them? |
Address linting issues raised in TheOdinProject#28277 - Insert additional blank line below headings 'Introduction' and 'Assignment. - Insert blank line above html tag. - Amend ordered list to always use 1. as prefix. - Improve link text description to avoid use of 'this'.
|
Attempted to address the preexisting linting issues. |
|
Is there something more that I need to do in order to complete the pull request? Not trying to be impatient - I'm just clueless, and don't want to be making other people wait on me! |
|
@MidlifeMechanicus Don't worry, just need to give it time for the reviewer/maintainer to review your changes. Your commits look good to me so they will probably be merged soon (keep in mind I am also new to github and oss). Maintainers here are doing this voluntarily and it's a lot of work, so don't stress if it is taking a long time (days-weeks) for your PR to get reviewed or merged (or rejected lol). |
|
All looks good. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a link to an article that I found very helpful in getting me started on the project.
Because
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection