-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hash map tests for Ruby #28263
Added hash map tests for Ruby #28263
Conversation
…yntax in Assignment section.
Hello :p Small gripe: In ruby style conventions, the names of "predicate methods" (methods that return a boolean) should end with a question mark to indicate that they return booleans. So on lines 52 and 109 in your proposed changes, |
@SumonGFC Ah i see, didn't know that. Thanks for letting me know, I'll undo that change! What about the the set method in lines 44 & 48? |
@elishamutang those lines are perfect. This set method is not supposed to return a boolean in the interface described by this project (think it is supposed to return the value that is associated with the key) So |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🙌
Like @SumonGFC said, the only suggestion I have is to append a ?
to the #has
method name (I forgot to mention this as something to keep in mind).
After that's fixed, we should be good to merge.
Co-authored-by: Josh Smith <[email protected]>
@JoshDevHub totally missed that last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Because
Allows users to populate their hash maps where it will exceed their load factor and ensuring that their hash map methods will still work as expected after growing their buckets (similar to this PR for JavaScript course).
This PR
Added a new section to test out user hash map implementation after
Assignment
section.Added dummy nodes to populate user hash map in the new section.
Issue
Closes #28257
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section