Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling React Apps lesson: Adds CSS preprocessors to list of ways to style react apps #26408

Conversation

Devansh-Baghel
Copy link
Contributor

Because

Thought it would be nice to mention CSS preprocessors when talking about styling React applications as a lot of people would already be using something like Scss before learning React and would like to continue doing that.

This PR

  • Mentions CSS preprocessors in the styling react apps lesson.

Issue

Does not close any issue or is related to any issue.

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Oct 3, 2023
@ManonLef ManonLef requested review from a team and codyloyd and removed request for a team October 4, 2023 11:59
@ManonLef
Copy link
Member

ManonLef commented Oct 4, 2023

Thank you, I've assigned a maintainer to review.

@codyloyd I've (randomly generated) assigned you for review. This might need to be a discussion instead but I'll let you decide, let me know if another status was better please :).

@codyloyd
Copy link
Member

codyloyd commented Oct 4, 2023

I don't think this mention needs to exist here, and I know that some people have some difficulty using preprocessors in their react apps. We don't want to have to troubleshoot that at this point in the curriculum.

@codyloyd codyloyd closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants