Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing_routes_and_controllers sections #26407

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix testing_routes_and_controllers sections #26407

merged 1 commit into from
Oct 3, 2023

Conversation

guillaume-giannantonio
Copy link
Contributor

I just added another section to separate the "Learning outcomes" part from the actual lesson. It wasn't making sense to have the full lesson in this part + when you were scrolling you would still see that you're reading the lesson from "Learning outcomes part".

I'm not quite sur about the title that I gave though ("Routes testing with supertest").

Because

"Learning outcomes" should not contains the entire lesson.

This PR

I just added a title to separate sections.

Issue

|

Additional Information

|

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

I just added another section to separate the "Learning outcomes"  part from the actual lesson. It wasn't making sense to have the full lesson in this part + when you were scrolling you would still see that you're reading the lesson from "Learning outcomes part". 

I'm not quite sur about the title that I gave though ("Routes testing with supertest").
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Oct 3, 2023
@ManonLef
Copy link
Member

ManonLef commented Oct 3, 2023

Good catch, thanks for adding this!

@ManonLef ManonLef merged commit cd75f08 into TheOdinProject:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants