Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Very Brief Intro to CS: changed quora link to avoid confusing answer #26396

Merged
merged 2 commits into from
Oct 1, 2023
Merged

A Very Brief Intro to CS: changed quora link to avoid confusing answer #26396

merged 2 commits into from
Oct 1, 2023

Conversation

kol3x
Copy link
Contributor

@kol3x kol3x commented Sep 30, 2023

Because

As I mentioned in this issue there was a confusing answer showing by default in a quora question (that was linked in the assignment section of intro to CS lesson) about algorithms in web dev. I changed the link so it goes straight to an answer explaining the topic, instead of the whole question with quora algos to decide what answer to show.
I changed it both in JS and Ruby paths. And also changed the same link in the following "Knowledge check" section.

This PR

  • In "A Very Brief Intro to CS" lesson of both Ruby and JS path, changed a link in both "Assignment" and "Knowledge check" lesson from a whole quora question to a specific answer.
  • Fixed some minor layout issues in the Ruby version of the lesson.

Issue

Closes #26219

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course labels Sep 30, 2023
@ManonLef ManonLef merged commit 169ac5b into TheOdinProject:main Oct 1, 2023
@kol3x kol3x deleted the cs_intro_quora_link_fix branch October 1, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Very Brief Intro to CS: Confusing quora answer
2 participants