Javascript OOP Principles: Rework "Single responsibility" example #26384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The example for the 'Single responsibility' in 'OOP Principles' lesson is written in a contradictory way which may confuse students:
The example firstly states the incorrect way by saying "So instead of this";
Then proceeds to show the correct way of solving the issue by saying "You should extract all the DOM manipulation into its own module and use it like so";
Lastly, contradicts the above by saying "In fact - the function isGameOver shouldn’t be calling the DOM function anyway. That should go elsewhere (directly in the game-loop).";
The example must make clear that there are two issues with the given code block and address each problem separately to avoid the apparent contradiction.
This PR
Issue
Closes #26243
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section