Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS, Deployment: Remove mention of database #26251

Closed
wants to merge 1 commit into from
Closed

NodeJS, Deployment: Remove mention of database #26251

wants to merge 1 commit into from

Conversation

OmarNaguib
Copy link
Contributor

@OmarNaguib OmarNaguib commented Aug 30, 2023

Because

text mentions how to deploy the database of the "Mini Message Board" project, but there is no database for said project

Edit: i just noticed that the second point is the assignment is entirely about a database too.
While it's an important point it dosen't seem to belong in the assignment.
I am happy to work on this, tell me if i should make an issue or just a pull request.

This PR

-removes mention of database

Issue

Closes #XXXXX

Additional Information

question: for a change like this, is an issue more suitable?

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Aug 30, 2023
@CouchofTomato CouchofTomato requested review from a team and fortypercenttitanium and removed request for a team August 31, 2023 11:19
@OmarNaguib OmarNaguib closed this by deleting the head repository Sep 4, 2023
@fortypercenttitanium
Copy link
Contributor

@OmarNaguib why did you close this?

@OmarNaguib
Copy link
Contributor Author

OmarNaguib commented Sep 13, 2023

@OmarNaguib why did you close this?

I removed my fork so it was closed automatically

We can reopen but we still have to think about where to put the second numbered point (the one about secrets)

edit: It seems i can't reopen because my old repo was deleted. i'll make another when we decide what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants