This repository was archived by the owner on Jan 1, 2026. It is now read-only.
Rewrite item removal logic to fix incorrect change and denomination breakdown #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Currency change calculation bug
Fixes the issue where players werent receiving correct change when paying with larger denominations.
Problem
When a player paid with a gold block (9g) for items costing 1-8g, they received incorrect change:
Solution
Complete rewrite of the
ItemCalculations.calculation()method with a cleaner algorithm:Also fixed a bug in
CalculationData.provideMaterials()where the default value was incorrect.Files Changed
Core/src/net/tnemc/core/currency/calculations/ItemCalculations.javaCore/src/net/tnemc/core/currency/calculations/CalculationData.javaTesting
Tested with all reported scenarios that are now returning correct change amounts.