Feat sprite porting#66
Open
CREAsTIVE wants to merge 21 commits into
Open
Conversation
Contributor
|
RSI Diff Bot; head commit ea583cc merging into 13e9595 Resources/Textures/Clothing/Belt/emt.rsi
Resources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi
Resources/Textures/Clothing/Hands/Gloves/janitor.rsi
Resources/Textures/Clothing/Hands/Gloves/latex.rsi
Resources/Textures/Clothing/Hands/Gloves/nitrile.rsi
Resources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi
Resources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi
Resources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi
Resources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi
Resources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi
Resources/Textures/Clothing/Head/Hats/warden.rsi
Resources/Textures/Clothing/Head/Helmets/paramedhelm.rsi
Resources/Textures/Clothing/Head/Hoods/rad.rsi
Resources/Textures/Clothing/Neck/Cloaks/hos.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi
Resources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi
Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi
Resources/Textures/Clothing/OuterClothing/Misc/chef.rsi
Resources/Textures/Clothing/OuterClothing/Suits/rad.rsi
Resources/Textures/Clothing/Shoes/Specific/galoshes.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi
Resources/Textures/Interface/Misc/job_icons.rsi
Resources/Textures/Objects/Devices/encryption_keys.rsi
Resources/Textures/Objects/Misc/Lights/lamp.rsi
Resources/Textures/Objects/Misc/id_cards.rsi
Resources/Textures/Clothing/OuterClothing/Coats/labcoat_chem.rsi
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (80)
📒 Files selected for processing (17)
💤 Files with no reviewable changes (15)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR standardizes ID card entity sprite layer definitions and consolidates clothing texture metadata across the asset tree. ID card prototypes adopt a unified multi-layer structure using department, subdepartment, and job-specific states. Clothing assets remove species-specific variants (Vox, Resomi, Reptilian, Harpy) in favor of body-slim equivalents, and copyright attributions are simplified or updated across RSI metadata files. Minor reference updates adjust firelock and recipe assets. ChangesSprite Layer and Texture Metadata Standardization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml`:
- Around line 494-497: The subdepartment layer entry (the `subdepartment` state
in the multi-layer block alongside `department` and `mime`) is missing a `color`
attribute; either add the same color used by `department` (e.g., set `color:
"`#878787`"` on the `subdepartment` layer) or remove the `subdepartment` layer
entirely if a subdepartment stripe should not be rendered for this card; update
the `subdepartment` entry in the existing multi-layer sequence accordingly.
In `@Resources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/meta.json`:
- Around line 25-28: The meta.json entry adds a new sprite state
"equipped-HAND-vox" with 4 directions but there is no corresponding PNG files in
the same folder; either add the missing sprite files named
"equipped-HAND-vox.png" (and directional variants if your pipeline expects
per-direction files) into
Resources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/ or change the meta
state name in meta.json to match an existing PNG (e.g., "equipped-HAND") so the
RSI loader finds a matching image; update meta.json's "name":
"equipped-HAND-vox" in that file if you choose the latter.
In `@Resources/Textures/Clothing/Hands/Gloves/latex.rsi/meta.json`:
- Around line 17-20: meta.json declares an RSI state "equipped-HAND-body-slim"
with 4 directions but there are no corresponding PNGs; either add the missing
sprite files named equipped-HAND-body-slim.png (and
equipped-HAND-body-slim-<direction>.png if your pipeline expects per-direction
naming) into Resources/Textures/Clothing/Hands/Gloves/latex.rsi/, ensuring they
match the project's naming and direction convention and dimensions, or
remove/rename the "equipped-HAND-body-slim" entry from
Resources/Textures/Clothing/Hands/Gloves/latex.rsi/meta.json so the manifest and
available PNG assets are consistent.
In
`@Resources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/meta.json`:
- Line 4: Remove the trailing comma character at the end of the string value for
the "copyright" JSON key in meta.json (the value currently ends with
"...pull/10758,"); edit the "copyright" value to remove the final comma so the
string reads "...pull/10758" without changing any other text or formatting.
In `@Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.json`:
- Around line 9-40: The meta.json for rndcoat is missing the
equipped-OUTERCLOTHING-body-slim and open-equipped-OUTERCLOTHING-body-slim
states, causing inconsistency with other coats; add two state entries named
"equipped-OUTERCLOTHING-body-slim" (with "directions": 4) and
"open-equipped-OUTERCLOTHING-body-slim" (with "directions": 4) to the "states"
array in Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.json,
matching the pattern used by rd_coat.rsi and detective.rsi so the renderer can
find body-slim variants (or alternatively add a short comment in the file
justifying why rndcoat intentionally omits these states if that is the intended
exception).
In `@Resources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/meta.json`:
- Around line 21-24: The meta.json adds a new sprite state
"equipped-INNERCLOTHING-body-slim" with directions:4 but the actual PNG is
missing; add a PNG file named exactly equipped-INNERCLOTHING-body-slim.png (and
any directional variants if your pipeline expects separate files) into the same
directory as the other sprites so the asset loader can find the state referenced
in meta.json, ensuring the filename matches the state key and follows the
existing naming convention (e.g., equipped-INNERCLOTHING-body-slim.png or
equipped-INNERCLOTHING-body-slim-<dir>.png).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2036f28a-6919-471f-a06d-074861014532
⛔ Files ignored due to path filters (261)
Resources/Textures/Clothing/Belt/emt.rsi/equipped-BELT.pngis excluded by!**/*.pngResources/Textures/Clothing/Belt/emt.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Belt/emt.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Belt/emt.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/equipped-HAND.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/janitor.rsi/equipped-HAND.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/janitor.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/janitor.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/janitor.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/latex.rsi/equipped-HAND.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/latex.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/latex.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/latex.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/nitrile.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Hands/Gloves/nitrile.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi/icon-flash.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi/off-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi/on-equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hats/warden.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hats/warden.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/equipped-HELMET-vox.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hoods/rad.rsi/equipped-HELMET-vox.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hoods/rad.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/Clothing/Head/Hoods/rad.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Neck/Cloaks/hos.rsi/equipped-NECK.pngis excluded by!**/*.pngResources/Textures/Clothing/Neck/Cloaks/hos.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/icon-open.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi/icon-open.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/icon-open.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/icon-open.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/icon-open.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/open-equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/open-inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/open-inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING-body-slim.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING-harpy.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING-reptilian.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING-resomi.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING-vox.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/equipped-OUTERCLOTHING-body-slim.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/equipped-OUTERCLOTHING-resomi.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING-body-slim.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING-harpy.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING-reptilian.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING-resomi.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING-vox.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Shoes/Specific/galoshes.rsi/equipped-FEET.pngis excluded by!**/*.pngResources/Textures/Clothing/Shoes/Specific/galoshes.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Shoes/Specific/galoshes.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Shoes/Specific/galoshes.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/equipped-INNERCLOTHING-monkey.pngis excluded by!**/*.pngResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/equipped-INNERCLOTHING.pngis excluded by!**/*.pngResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Boxer.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Chaplain.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/CustomId.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Inspector.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Janitor.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Lawyer.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Librarian.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Passenger.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/ServiceWorker.pngis excluded by!**/*.pngResources/Textures/Interface/Misc/job_icons.rsi/Zookeeper.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_blue.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_gold.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_gray.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_orange.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_red.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_rusted.pngis excluded by!**/*.pngResources/Textures/Objects/Devices/encryption_keys.rsi/crypt_silver.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/Lights/lamp.rsi/lamp-on.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/Lights/lamp.rsi/lamp.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/admin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/assistant.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/atmospherictechnician.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/bartender.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/black.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/botanist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/boxer.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/captain.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/cargotechnician.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/carp.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/cc.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/centcom.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/chaplain.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/chemist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/clown.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/cook.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/curator.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/death.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/department.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/departmenthead.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/detective.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/flame.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/geneticist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/gladiator.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/headofpersonnel.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/idadmin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/idcentcom.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/idinspector.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/idwizard.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/janitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/lawyer.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/mailcarrier.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/martialartist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/medicaldoctor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/mime.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/musician.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/paramedic.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/passenger.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/prisoner.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/prisonguard.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/psychologist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/rainbow.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/roboticist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/rpg.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/scientist.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/securityofficer.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/senior.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/shaftminer.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/stationengineer.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/subdepartment.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/syndicate.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/visitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/warden.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/wizard.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/id_cards.rsi/zookeeper.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/adv_capacitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/adv_scan_module.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/advanced_matter_bin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/bluespace_matter_bin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/capacitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/femto_mani.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/high_micro_laser.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/matter_bin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/micro_laser.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/micro_mani.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/nano_mani.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/pico_mani.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/quadratic_capacitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/quadultra_micro_laser.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/scan_module.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/super_capacitor.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/super_matter_bin.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/super_scan_module.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/triphasic_scan_module.pngis excluded by!**/*.pngResources/Textures/Objects/Misc/stock_parts.rsi/ultra_high_micro_laser.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/jaws_cutter.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/jaws_pry.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/syn_jaws_cutter.pngis excluded by!**/*.pngResources/Textures/Objects/Tools/jaws_of_life.rsi/syn_jaws_pry.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/empgrenade.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/empgrenade.rsi/primed.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/flashbang.rsi/equipped-BELT.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/flashbang.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/flashbang.rsi/primed.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/grenade.rsi/icon.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/grenade.rsi/primed.pngis excluded by!**/*.pngResources/Textures/Objects/Weapons/Grenades/modular.rsi/complete.pngis excluded by!**/*.png
📒 Files selected for processing (39)
Resources/Prototypes/Entities/Objects/Misc/identification_cards.ymlResources/Prototypes/_Goobstation/Entities/Objects/Misc/identification_cards.ymlResources/Textures/Clothing/Belt/emt.rsi/meta.jsonResources/Textures/Clothing/Hands/Gloves/Color/yellow.rsi/meta.jsonResources/Textures/Clothing/Hands/Gloves/janitor.rsi/meta.jsonResources/Textures/Clothing/Hands/Gloves/latex.rsi/meta.jsonResources/Textures/Clothing/Hands/Gloves/nitrile.rsi/meta.jsonResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertengineer.rsi/meta.jsonResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertjanitor.rsi/meta.jsonResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertleader.rsi/meta.jsonResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertmedical.rsi/meta.jsonResources/Textures/Clothing/Head/Hardsuits/ERThelmets/ertsecurity.rsi/meta.jsonResources/Textures/Clothing/Head/Hats/warden.rsi/meta.jsonResources/Textures/Clothing/Head/Helmets/paramedhelm.rsi/meta.jsonResources/Textures/Clothing/Head/Hoods/rad.rsi/meta.jsonResources/Textures/Clothing/Neck/Cloaks/hos.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_chem.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_researcher.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Misc/chef.rsi/meta.jsonResources/Textures/Clothing/OuterClothing/Suits/rad.rsi/meta.jsonResources/Textures/Clothing/Shoes/Specific/galoshes.rsi/meta.jsonResources/Textures/Clothing/Uniforms/Jumpsuit/rnd.rsi/meta.jsonResources/Textures/Interface/Misc/job_icons.rsi/meta.jsonResources/Textures/Objects/Misc/id_cards.rsi/meta.jsonResources/Textures/Objects/Misc/stock_parts.rsi/meta.json
Comment on lines
+494
to
+497
| - state: department | ||
| color: "#878787" | ||
| - state: subdepartment | ||
| - state: mime |
Contributor
There was a problem hiding this comment.
Subdepartment layer missing color attribute.
The subdepartment layer at line 496 lacks a color attribute, while the department layer above it has color: "#878787". All other ID cards in this file that use the multi-layer scheme include a color for every department/subdepartment layer, making this inconsistent.
Either add a matching color (e.g., color: "#878787"), or remove the subdepartment layer entirely if mime should not display a subdepartment stripe.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml` around
lines 494 - 497, The subdepartment layer entry (the `subdepartment` state in the
multi-layer block alongside `department` and `mime`) is missing a `color`
attribute; either add the same color used by `department` (e.g., set `color:
"`#878787`"` on the `subdepartment` layer) or remove the `subdepartment` layer
entirely if a subdepartment stripe should not be rendered for this card; update
the `subdepartment` entry in the existing multi-layer sequence accordingly.
| "version": 1, | ||
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758, resprite by muriexlol, equipped-OUTERCLOTHING-resomi made by Pofitlo", | ||
| "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758,", |
Contributor
There was a problem hiding this comment.
Remove trailing comma from copyright string.
The copyright string ends with a trailing comma (...pull/10758,), which appears to be a copy-paste artifact. While this doesn't cause a JSON syntax error (it's inside the string value), it should be removed for consistency and cleanliness.
✂️ Proposed fix
- "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758,",
+ "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758,", | |
| "copyright": "Edit by Nairodian (github) of labcoat.rsi from Space-Station-14 at pull request https://github.com/space-wizards/space-station-14/pull/10758", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@Resources/Textures/Clothing/OuterClothing/Coats/labcoat_senior_physician.rsi/meta.json`
at line 4, Remove the trailing comma character at the end of the string value
for the "copyright" JSON key in meta.json (the value currently ends with
"...pull/10758,"); edit the "copyright" value to remove the final comma so the
string reads "...pull/10758" without changing any other text or formatting.
Comment on lines
+9
to
+40
| "states": [ | ||
| { | ||
| "name": "icon" | ||
| }, | ||
| "states": [ | ||
| { | ||
| "name": "icon" | ||
| }, | ||
| { | ||
| "name": "icon-open" | ||
| }, | ||
| { | ||
| "name": "equipped-OUTERCLOTHING", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-equipped-OUTERCLOTHING", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "equipped-OUTERCLOTHING-vox", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-equipped-OUTERCLOTHING-vox", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "equipped-OUTERCLOTHING-resomi", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-equipped-OUTERCLOTHING-resomi", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "inhand-left", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "inhand-right", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-inhand-left", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-inhand-right", | ||
| "directions": 4 | ||
| } | ||
| ] | ||
| { | ||
| "name": "icon-open" | ||
| }, | ||
| { | ||
| "name": "equipped-OUTERCLOTHING", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-equipped-OUTERCLOTHING", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "inhand-left", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "inhand-right", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-inhand-left", | ||
| "directions": 4 | ||
| }, | ||
| { | ||
| "name": "open-inhand-right", | ||
| "directions": 4 | ||
| } | ||
| ] |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check body-slim pattern consistency across science/research coat sprites
rg -n "body-slim" Resources/Textures/Clothing/OuterClothing/Coats/ -g "*.json" -C2Repository: TheMaidDev/Maid-14
Length of output: 7261
Add missing *-body-slim equipped states for rndcoat (or justify the exception).
Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.jsondefinesequipped-OUTERCLOTHING/open-equipped-OUTERCLOTHINGbut has noequipped-OUTERCLOTHING-body-slimoropen-equipped-OUTERCLOTHING-body-slim.- Other coats in the same folder (e.g.,
rd_coat.rsi,labcoat_robo.rsi,detective.rsi) include those*-body-slimstates, sorndcoatshould be updated for consistency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.json` around
lines 9 - 40, The meta.json for rndcoat is missing the
equipped-OUTERCLOTHING-body-slim and open-equipped-OUTERCLOTHING-body-slim
states, causing inconsistency with other coats; add two state entries named
"equipped-OUTERCLOTHING-body-slim" (with "directions": 4) and
"open-equipped-OUTERCLOTHING-body-slim" (with "directions": 4) to the "states"
array in Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi/meta.json,
matching the pattern used by rd_coat.rsi and detective.rsi so the renderer can
find body-slim variants (or alternatively add a short comment in the file
justifying why rndcoat intentionally omits these states if that is the intended
exception).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Массовый портинг спрайтов
Изменения
🆑 CREAsTIVE
Summary by CodeRabbit
Release Notes
Visual Updates
Changes