Arrivals rework#65
Conversation
github-actions
Bot
added
S: Untriaged
Changes: UI
Changes: Audio
Changes: Map
and removed
S: Untriaged
labels
|
Warning Review limit reached
More reviews will be available in 45 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR removes the spawn priority user preference from the character creation UI and server persistence, adds a custom sound override system for FTL hyperspace transitions, and performs large-scale cleanup of the arrivals shuttle map by removing Godmode components and refining entity damage/construction constraints. ChangesSpawn Priority Removal
Arrivals Shuttle Rework
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs (1)
1531-1535: 💤 Low valueUnreachable dead code after spawn priority UI removal.
The
SetSpawnPrioritymethod is no longer called now that the spawn priority UI (specificallySpawnPriorityButton.OnItemSelectedat line 583) is disabled. Consider commenting it out or removing it for consistency with the other disabled spawn priority code.♻️ Optional refactor to comment out unused method
+ // MAID BEGIN remove-spawn-priority + /* private void SetSpawnPriority(SpawnPriorityPreference newSpawnPriority) { Profile = Profile?.WithSpawnPriorityPreference(newSpawnPriority); SetDirty(); } + */ + // MAID END remove-spawn-priority🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs` around lines 1531 - 1535, The SetSpawnPriority method is dead code because the spawn priority UI (SpawnPriorityButton.OnItemSelected) is disabled; remove or comment out the private SetSpawnPriority(SpawnPriorityPreference newSpawnPriority) method in HumanoidProfileEditor.xaml.cs to keep code consistent with other disabled spawn-priority logic, and run a search for any remaining references to SetSpawnPriority or SpawnPriorityButton.OnItemSelected to ensure no callers remain before committing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Server/Shuttles/Systems/ShuttleSystem.FasterThanLight.cs`:
- Around line 445-448: The startup code chooses a custom sound via TryComp +
CustomFTLSoundComponent.StartupSound but UpdateFTLStarting still uses the
hardcoded _startupSound, so the custom override is lost mid-sequence; modify the
selection to persist the chosen clip (e.g., write the chosen sound resource into
the component like CustomFTLSoundComponent.CurrentStartupSound or another
shuttle-state field when calling _audio.PlayPvs) and then change
UpdateFTLStarting to read that persisted value (falling back to _startupSound if
null) instead of always using _startupSound so the same clip plays for the
departure clip.
In `@Resources/Prototypes/Entities/Structures/Doors/Airlocks/access.yml`:
- Around line 1229-1237: AirlockExternalGlassShuttleArrivals still inherits a
ContainerFill and AccessReader from its parent chain so it isn't truly public;
override the inherited components in this prototype by adding a local
ContainerFill that removes the `board` electronics (e.g., set `containers:` with
no `board` entry or an empty list) and also override/remove the AccessReader
(clear `containerAccessProvider` or remove the AccessReader component) so no
inherited `board` or `containerAccessProvider: board` remains; reference the
prototype name AirlockExternalGlassShuttleArrivals and components PriorityDock,
ContainerFill, DoorElectronics/DoorElectronicsExternal, and AccessReader when
making these overrides.
---
Nitpick comments:
In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs`:
- Around line 1531-1535: The SetSpawnPriority method is dead code because the
spawn priority UI (SpawnPriorityButton.OnItemSelected) is disabled; remove or
comment out the private SetSpawnPriority(SpawnPriorityPreference
newSpawnPriority) method in HumanoidProfileEditor.xaml.cs to keep code
consistent with other disabled spawn-priority logic, and run a search for any
remaining references to SetSpawnPriority or SpawnPriorityButton.OnItemSelected
to ensure no callers remain before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 43912285-c47c-46db-8aaf-d2bf13a261b5
⛔ Files ignored due to path filters (3)
Resources/Audio/Effects/Shuttle/Arrivals/hyperspace_begin.oggis excluded by!**/*.oggResources/Audio/Effects/Shuttle/Arrivals/hyperspace_end.oggis excluded by!**/*.oggResources/Audio/Effects/Shuttle/Arrivals/hyperspace_progress.oggis excluded by!**/*.ogg
📒 Files selected for processing (7)
Content.Client/Lobby/UI/HumanoidProfileEditor.xamlContent.Client/Lobby/UI/HumanoidProfileEditor.xaml.csContent.Server/Database/ServerDbBase.csContent.Server/Shuttles/Systems/ShuttleSystem.FasterThanLight.csContent.Server/_Maid/FasterThanLight/Components/CustomFTLSoundComponent.csResources/Maps/Shuttles/arrivals.ymlResources/Prototypes/Entities/Structures/Doors/Airlocks/access.yml
2 participants
Описание
Небольшой реворк шаттла прибытия
Изменения
🆑 CREAsTIVE
Summary by CodeRabbit
New Features
Changes