Added Global average pooling #9863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
enhancement
tianyizheng02
requested changes
Oct 17, 2023
Comment on lines
+12
to
15
| # Max pooling Function | ||
| def max_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | ||
| """ | ||
| This function is used to perform maxpooling on the input array of 2D matrix(image) |
There was a problem hiding this comment.
Suggested change
| # Max pooling Function | |
| def max_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | |
| """ | |
| This function is used to perform maxpooling on the input array of 2D matrix(image) | |
| def max_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | |
| """ | |
| Performs max pooling on the input image matrix |
The comment at the top of the function is unnecessary because we already have the docstring to explain what the algorithm does
| @@ -15,10 +20,10 @@ def maxpooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | |||
| Returns: | |||
| numpy array of maxpooled matrix | |||
There was a problem hiding this comment.
Suggested change
| numpy array of maxpooled matrix | |
| The max pooled matrix |
Comment on lines
+68
to
71
| # Average pooling Function | ||
| def avg_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | ||
| """ | ||
| This function is used to perform avgpooling on the input array of 2D matrix(image) |
There was a problem hiding this comment.
Suggested change
| # Average pooling Function | |
| def avg_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | |
| """ | |
| This function is used to perform avgpooling on the input array of 2D matrix(image) | |
| def avg_pooling(arr: np.ndarray, size: int, stride: int) -> np.ndarray: | |
| """ | |
| Perform average pooling on the input image matrix |
Comment on lines
76
to
77
| Returns: | ||
| numpy array of avgpooled matrix |
There was a problem hiding this comment.
Suggested change
| Returns: | |
| numpy array of avgpooled matrix | |
| Returns: | |
| The average pooled matrix |
Comment on lines
+123
to
+131
| # Global Average pooling Function | ||
| def global_average_pooling(arr: np.ndarray) -> np.ndarray: | ||
| """ | ||
| This function performs global average pooling on the input 2D matrix (image). | ||
| Args: | ||
| arr: numpy array | ||
| The input 2D matrix. | ||
| Returns: | ||
| numpy array of the global average pooled matrix. |
There was a problem hiding this comment.
Suggested change
| # Global Average pooling Function | |
| def global_average_pooling(arr: np.ndarray) -> np.ndarray: | |
| """ | |
| This function performs global average pooling on the input 2D matrix (image). | |
| Args: | |
| arr: numpy array | |
| The input 2D matrix. | |
| Returns: | |
| numpy array of the global average pooled matrix. | |
| def global_avg_pooling(arr: np.ndarray) -> np.ndarray: | |
| """ | |
| Performs global average pooling on the input image matrix. | |
| Args: | |
| arr: the input 2D matrix. | |
| Returns: | |
| The global average pooled matrix |
Changed name from "...average..." to "...avg..." for consistency with avg_pooling
| return global_avg_pooled_matrix | ||
|
|
||
|
|
||
| # Test with Images |
There was a problem hiding this comment.
Suggested change
| # Test with Images |
| if __name__ == "__main__": | ||
| from doctest import testmod | ||
|
|
||
| testmod(name="avgpooling", verbose=True) | ||
| testmod(name="average_pooling", verbose=True) |
There was a problem hiding this comment.
Suggested change
| testmod(name="average_pooling", verbose=True) | |
| testmod(name="pooling_functions", verbose=True) |
| image = Image.open("path_to_image") | ||
| image = Image.open("/path_to_image") | ||
|
|
||
| # Converting the image to numpy array and max_pooling, displaying the result |
There was a problem hiding this comment.
Suggested change
| # Converting the image to numpy array and max_pooling, displaying the result | |
| # Converting the image to numpy array and max pooling, displaying the result |
|
|
||
| # Converting the image to numpy array and maxpooling, displaying the result | ||
| # Converting the image to numpy array and average_pooling, displaying the result |
There was a problem hiding this comment.
Suggested change
| # Converting the image to numpy array and average_pooling, displaying the result | |
| # Converting the image to numpy array and average pooling, displaying the result |
|
|
||
| # Converting the image to numpy array and averagepooling, displaying the result | ||
| # Converting the image to numpy array and average_pooling, displaying the result |
There was a problem hiding this comment.
Suggested change
| # Converting the image to numpy array and average_pooling, displaying the result | |
| # Converting the image to numpy array and global average pooling, displaying the result |
tianyizheng02
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: