Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added function that checks if a string is an isogram #7608

Merged
merged 10 commits into from
Oct 26, 2022
Merged

Added function that checks if a string is an isogram #7608

merged 10 commits into from
Oct 26, 2022

Conversation

M3talM0nk3y
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 25, 2022
cclauss
cclauss reviewed Oct 25, 2022
View reviewed changes
cclauss
cclauss reviewed Oct 25, 2022
View reviewed changes
cclauss
cclauss reviewed Oct 25, 2022
View reviewed changes
cclauss
cclauss reviewed Oct 25, 2022
View reviewed changes
M3talM0nk3y and others added 4 commits October 25, 2022 21:53
@M3talM0nk3y
Made function name more self-documenting. Raise ValueError if string …
fe25aea 
…contains 1 or more digits. Renamed file. Lowercase string inside function.
@M3talM0nk3y
Made function name more self-documenting. Raise ValueError if string …
ff93d43 
…contains 1 or more digits. Renamed file. Lowercase string inside function.
@M3talM0nk3y
Removed check_isogram.py (file renamed).
a1828c6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7dba5f1 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 26, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 26, 2022
@M3talM0nk3y M3talM0nk3y requested a review from cclauss October 26, 2022 02:11
@M3talM0nk3y
Copy link
Contributor Author

@cclauss Thanks for your feedback. :)

ChrisO345
ChrisO345 requested changes Oct 26, 2022
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 26, 2022
@ChrisO345 ChrisO345 merged commit 68f6e9a into TheAlgorithms:master Oct 26, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022
@ChrisO345 ChrisO345 added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed tests are failing Do not merge until tests pass labels Oct 26, 2022
@M3talM0nk3y M3talM0nk3y deleted the isogram branch October 26, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisO345 ChrisO345 ChrisO345 approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M3talM0nk3y @cclauss @ChrisO345