Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes across multiple algorithms #6912

Merged
merged 13 commits into from
Oct 16, 2022
Merged

Misc fixes across multiple algorithms #6912

merged 13 commits into from
Oct 16, 2022

Conversation

CenTdemeern1
Copy link
Contributor

@CenTdemeern1 CenTdemeern1 commented Oct 10, 2022 •
edited
Loading

Describe your change:

This change fixes a typo where __name__ == "__main__" was accidentally written as __name__ == "main".

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 10, 2022
@dhruvmanila
Copy link
Member

Hi, thanks for the PR. Can you check if there any similar bugs elsewhere? If none, I'll merge this.

@CenTdemeern1
Copy link
Contributor Author

CenTdemeern1 commented Oct 10, 2022 •
edited
Loading

Hi, thanks for the PR. Can you check if there any similar bugs elsewhere? If none, I'll merge this.

No, not bugs like this (at least not that I am aware of), but I have found a ton of other misc issues (more than 65, according to my linter) which I have fixed locally, and I am currently debating on how I should PR them, since they are spread across a ton of files

@CenTdemeern1
Copy link
Contributor Author

@dhruvmanila I sent you a DM on Discord regarding those other issues - for now I would say you can merge this

@dhruvmanila
Copy link
Member

What kind of issues and which linter are you talking about? I think you can just include all of them in this PR under misc fixes.

@CenTdemeern1
Copy link
Contributor Author

CenTdemeern1 commented Oct 11, 2022 •
edited
Loading

What kind of issues

Everything from changing list(filter()) to list comprehension to fixing a zero division (#6916).

and which linter are you talking about?

Snyk code quality.

I think you can just include all of them in this PR under misc fixes.

Sure, I could, if you want me to. Are you sure you don't actually want to see the changes first?

@dhruvmanila
Copy link
Member

dhruvmanila commented Oct 11, 2022 •
edited
Loading

Are you sure you don't actually want to see the changes first?

I'll be looking at them once you commit in this PR :)

If it's possible to visit some public URL to go through everything synk captured, that would be helpful as well.

@CenTdemeern1
Copy link
Contributor Author

If it's possible to visit some public URL to go through everything synk captured, that would be helpful as well.

I don't think so, sadly - I think Snyk code quality is only available with Snyk's IDE plugins

I'll be looking at them once you commit in this PR :)

Okay then, I'll commit my changes when I get home - that should be in about 4 - 4.5 hours (since the changes are saved on my computer at home and not my laptop)

@CenTdemeern1
Misc fixes
8f3fa34 
@dhruvmanila told me to commit these here so here we go
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 11, 2022
@CenTdemeern1
Copy link
Contributor Author

Uh oh, some checks failed, I thought I ran all the tests and formatting and stuff yesterday? I'll look into it in a bit.

@CenTdemeern1
Copy link
Contributor Author

Okay, so:
Project Euler / project-euler -> I didn't touch the file that is making this check fail
build / build (pull_request) -> I'll fix this one right now
pre-commit.ci - pr -> I'll try to fix this but mypy is weird so I don't know, maybe someone could help me with this one (because mypy is weird with deconstruction)

@dhruvmanila dhruvmanila removed the request for review from Kush1101 October 11, 2022 17:09
@dhruvmanila dhruvmanila self-assigned this Oct 11, 2022
dhruvmanila
dhruvmanila requested changes Oct 11, 2022
View reviewed changes
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 11, 2022
@dhruvmanila dhruvmanila changed the title Fix __name__ == "main" typo Misc fixes across multiple algorithms Oct 11, 2022
@CenTdemeern1
Copy link
Contributor Author

Welp, guess I am solving everyone else's issues. I'll do it when I get home.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed merge conflicts Open a new PR or rebase on the latest commit and removed awaiting changes A maintainer has requested changes to this PR labels Oct 13, 2022
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 13, 2022
@dhruvmanila
Copy link
Member

Also, please don't @ anyone in the commit message, you can request for review again once you make the requested changes.

@CenTdemeern1
Copy link
Contributor Author

Also, please don't @ anyone in the commit message, you can request for review again once you make the requested changes.

Oh sorry, I thought it was okay because someone did the same to me before

dhruvmanila
dhruvmanila reviewed Oct 13, 2022
View reviewed changes
@dhruvmanila
Copy link
Member

Oh sorry, I thought it was okay because someone did the same to me before

No problem! :)

Please check the CI failures, after that we can merge.

@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 15, 2022
@CenTdemeern1
Copy link
Contributor Author

Please check the CI failures, after that we can merge.

build / build - This one is failing because of scikit-fuzzy, I still don't understand how to deal with that
pre-commit.ci - pr - Should be fixed now?
Merge conflicts - I'll go resolve those ASAP

@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 15, 2022
@CenTdemeern1
Copy link
Contributor Author

Merge conflicts should be resolved now!

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 16, 2022
dhruvmanila
dhruvmanila approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2022
@dhruvmanila dhruvmanila merged commit 0469853 into TheAlgorithms:master Oct 16, 2022
@CaedenPH CaedenPH mentioned this pull request Oct 18, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@CaedenPH CaedenPH CaedenPH approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

@dhruvmanila dhruvmanila

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CenTdemeern1 @dhruvmanila @cclauss @CaedenPH